feat: ui.footer #1100
Open
feat: ui.footer #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
requested changes
Jan 31, 2025
Comment on lines
16
to
17
| variant="info", | ||
| footer=ui.link("Download support logs"), |
There was a problem hiding this comment.
I'd group the footer together with the heading/content, rather than having the variant in the middle.
Suggested change
| variant="info", | |
| footer=ui.link("Download support logs"), | |
| footer=ui.link("Download support logs"), | |
| variant="info", |
plugins/ui/docs/components/footer.md
Outdated
|
|
||
| ## Slots | ||
|
|
||
| `ui.footer` is intended to be used in container components with layouts that provide a slot for `ui.footer` (and other supported elements). These components handle the layout and styling of such elements for you. See [`ui.dialog`](./dialog.md#content) and [`ui.contextual_help`](./contextual_help#example) for more detailed examples. |
There was a problem hiding this comment.
Suggested change
| `ui.footer` is intended to be used in container components with layouts that provide a slot for `ui.footer` (and other supported elements). These components handle the layout and styling of such elements for you. See [`ui.dialog`](./dialog.md#content) and [`ui.contextual_help`](./contextual_help#example) for more detailed examples. | |
| `ui.footer` is intended to be used in container components with layouts that provide a slot for `ui.footer` (and other supported elements). These components handle the layout and styling of such elements for you. See [`ui.dialog`](./dialog.md#content) and [`ui.contextual_help`](./contextual_help#example) for examples of a footer used in the context of a container. |
plugins/ui/docs/components/footer.md
Outdated
Comment on lines
21
to
34
| ```python | ||
| from deephaven import ui | ||
|
|
||
|
|
||
| my_footer_order_example = ui.dialog( | ||
| ui.heading("Customer Support Request"), | ||
| ui.content( | ||
| "We have received your support request and are currently reviewing it. Our team will get back to you soon." | ||
| ), | ||
| ui.footer( | ||
| "Ticket ID: #123456 | Status: In Progress | Support email: [email protected]" | ||
| ), | ||
| ) | ||
| ``` |
There was a problem hiding this comment.
This example is weird, because we're not using a dialog like a dialog (triggering it and opening it), it's just appearing in a panel.
I'd just get rid of this example, it's fine to refer to Dialog/ContextualHelp for other examples.
Suggested change
| ```python | |
| from deephaven import ui | |
| my_footer_order_example = ui.dialog( | |
| ui.heading("Customer Support Request"), | |
| ui.content( | |
| "We have received your support request and are currently reviewing it. Our team will get back to you soon." | |
| ), | |
| ui.footer( | |
| "Ticket ID: #123456 | Status: In Progress | Support email: [email protected]" | |
| ), | |
| ) | |
| ``` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #878